Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10583
Change subject: IMPALA-7110. Fix some warnings from error-prone ...................................................................... IMPALA-7110. Fix some warnings from error-prone * Fixes several cases of Preconditions.checkNotNull(<bool>) which were ineffective. Instead, we should use Preconditions.checkState. * Fixed a case of synchronizing on a non-final class member, which is a bad practice. * Fixed a case of trying to stringify an array instead of using Joiner to join it to a human-readable representation. * Fixed a case where the format string in String.format didn't match the number of arguments passed. I elected not to enable error-prone in the maven settings since it increases compilation time noticeably. Change-Id: Ie9bfadecb5b92bba4fc7921a6f87f249ed90e771 --- M fe/src/main/java/org/apache/impala/analysis/CreateUdfStmt.java M fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java M fe/src/main/java/org/apache/impala/analysis/Path.java M fe/src/main/java/org/apache/impala/catalog/DiskIdMapper.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/main/java/org/apache/impala/catalog/StructType.java M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java 7 files changed, 9 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/10583/1 -- To view, visit http://gerrit.cloudera.org:8080/10583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie9bfadecb5b92bba4fc7921a6f87f249ed90e771 Gerrit-Change-Number: 10583 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org>
