Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10583 )
Change subject: IMPALA-7110. Fix some warnings from error-prone ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10583/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10583/1//COMMIT_MSG@21 PS1, Line 21: I elected not to enable error-prone in the maven settings since it It's likely posssibly to use Maven profiles to make this an optional flag. Not a blocking issue, but I'd be happy to review a new profile that does this. We could likely run it in parallel during GVOs without much harm, like we do with clang-tidy and such. -- To view, visit http://gerrit.cloudera.org:8080/10583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bfadecb5b92bba4fc7921a6f87f249ed90e771 Gerrit-Change-Number: 10583 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Jun 2018 20:19:04 +0000 Gerrit-HasComments: Yes
