Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22847 )
Change subject: IMPALA-12201: Stabilize TestFetch ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22847/1/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22847/1/tests/common/impala_connection.py@1155 PS1, Line 1155: def get_operation_status(self, operation_handle): : return self.__get_operation(operation_handle).get_status() Nit: get_operation_status() here is the same as get_state() http://gerrit.cloudera.org:8080/#/c/22847/1/tests/query_test/test_fetch.py File tests/query_test/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/22847/1/tests/query_test/test_fetch.py@92 PS1, Line 92: # Use beeswax_client because it is more consistent in fetching 5 rows at a time. Nit: This comment is out of date http://gerrit.cloudera.org:8080/#/c/22847/1/tests/query_test/test_fetch.py@147 PS1, Line 147: # This is the finalization fetch. : result = client.fetch(query, handle) : assert result is not None This test is intentionally not fetching all the way. What happens if we don't do this final fetch? I think we were expecting the close_query() to result in a round-trip to the server. -- To view, visit http://gerrit.cloudera.org:8080/22847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52651df37a318357711d26d2414e025cce4185c3 Gerrit-Change-Number: 22847 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 02 May 2025 20:07:14 +0000 Gerrit-HasComments: Yes
