Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22847 )
Change subject: IMPALA-12201: Stabilize TestFetch ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22847/3/tests/query_test/test_fetch.py File tests/query_test/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/22847/3/tests/query_test/test_fetch.py@146 PS3, Line 146: # This simulate the finalization fetch when calling : # ImpylaHS2Connection.close_query(). Need to do this manually because : # MinimalHS2Connection.close_query() does not automatically do that. : result = client.fetch(query, handle) : assert result is not None : # Grab profile before closing handle. : runtime_profile = client.get_runtime_profile(handle) I tried this out locally, and for me, it works to fetch the runtime profile after closing the query. i.e. finally: client.close_query(handle) runtime_profile = client.get_runtime_profile(handle) Then, the final fetch is not necessary as the close query does the 6th RPC. We can also verify that we only fetched 25 rows: assert "NumRowsFetched: {0} ({0})".format(25) in runtime_profile -- To view, visit http://gerrit.cloudera.org:8080/22847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52651df37a318357711d26d2414e025cce4185c3 Gerrit-Change-Number: 22847 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 02 May 2025 20:58:47 +0000 Gerrit-HasComments: Yes
