Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22844 )
Change subject: IMPALA-13850 (part 2): Stabilize test_restart_services.py ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22844/1/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/22844/1/tests/custom_cluster/test_restart_services.py@398 PS1, Line 398: tbl_name = unique_database + ".join_aa" > Narrowed down the change in ps2. Oh, I thought this behavior change is transparent to users. But in this catalogd-restart scenario, queries will still fail between the first and second catalog updates, is that correct? If so, we do need a mechanism for such queries to wait until the second catalog update arrives. I'm OK with this test fix and leave the work to be done in another JIRA. http://gerrit.cloudera.org:8080/#/c/22844/3/tests/util/catalog_monitor.py File tests/util/catalog_monitor.py: http://gerrit.cloudera.org:8080/#/c/22844/3/tests/util/catalog_monitor.py@36 PS3, Line 36: self.impalad.service.get_metric_value('catalog.curr-serviceid')] nit: can we log the initial id? -- To view, visit http://gerrit.cloudera.org:8080/22844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97f6f692506de0bbf2e1445f83bed824dc8298fd Gerrit-Change-Number: 22844 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 06 May 2025 01:52:31 +0000 Gerrit-HasComments: Yes
