Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22844 )
Change subject: IMPALA-13850 (part 2): Stabilize test_restart_services.py ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22844/1/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/22844/1/tests/custom_cluster/test_restart_services.py@398 PS1, Line 398: tbl_name = unique_database + ".join_aa" > Oh, I thought this behavior change is transparent to users. But in this cat No. The test fail because it has not heard the first topic update from restarted CatalogD. CatalogChangeMonitor only help to wait a little bit more until it is ensured that first topic update from restarted CatalogD arrived at coordinator. I think test_restart_catalogd_with_local_catalog expect that during loop 6-9, CatalogD has managed to be available, but it is not. Its readiness criteria is here: https://github.com/apache/impala/blob/55804f78740bf5e05aaee2634dec249fefb431a0/tests/common/impala_cluster.py#L738-L740 Maybe a more practical fix is to wait here a little bit more here, waiting until CatalogD send at least 1-2 topic update. -- To view, visit http://gerrit.cloudera.org:8080/22844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97f6f692506de0bbf2e1445f83bed824dc8298fd Gerrit-Change-Number: 22844 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 06 May 2025 03:29:23 +0000 Gerrit-HasComments: Yes
