Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same ...................................................................... Patch Set 5: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@499 PS4, Line 499: unless > nit: unless Done http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@514 PS4, Line 514: upedContentFiles icebergFiles = IcebergUtil.getIcebergFiles(this, : new ArrayList<>(), /*timeTravelSpec=*/null); > I know this comment is from the original code, but I find it difficult to u Thanks for the suggestion. I rephrased a bit to emphasize that Iceberg schema loading must precede hdfs table loading. http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@551 PS4, Line 551: } > unused method, see also the comment on L246 Nice catch, done. -- To view, visit http://gerrit.cloudera.org:8080/22432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664 Gerrit-Change-Number: 22432 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 06 May 2025 16:58:26 +0000 Gerrit-HasComments: Yes
