Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@551 PS4, Line 551: } > Now that this set method is removed, I wonder if there is any way we can up We can still directly update the field in this class. E.g. we do it in loadTableMetadata() at L489. I stopped using this method because we now update icebergApiTable_ and currentMetadataLocation_ at different places. -- To view, visit http://gerrit.cloudera.org:8080/22432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664 Gerrit-Change-Number: 22432 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 May 2025 14:41:47 +0000 Gerrit-HasComments: Yes
