Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )
Change subject: IMPALA-14039: __restore_query_options should unset query option ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22862/3/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22862/3/tests/common/impala_connection.py@639 PS3, Line 639: del self.__query_options[name] I think this wrong. Once set, the key should stay, even if the value is an empty string. Impala can interpret empty value as query option reset. -- To view, visit http://gerrit.cloudera.org:8080/22862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923 Gerrit-Change-Number: 22862 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 07 May 2025 02:27:04 +0000 Gerrit-HasComments: Yes
