Hello Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22862

to look at the new patch set (#4).

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 10 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/22862/4
--
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>

Reply via email to