Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22554 )
Change subject: IMPALA-13593: Enable event processor to consume ALTER_PARTITIONS events from metastore ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22554/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22554/2//COMMIT_MSG@24 PS2, Line 24: event. Also, bigger time outs were added in this test as there was > I added bigger timeout specific to this test. This test is failing 2-3 time Ack http://gerrit.cloudera.org:8080/#/c/22554/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22554/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@131 PS2, Line 131: ALTER_DATABASE("ALTER_DATABASE"), > I want to use this for batch events and ALTER_PARTITIONS for the new event. Ack http://gerrit.cloudera.org:8080/#/c/22554/2/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22554/2/tests/custom_cluster/test_events_custom_configs.py@1514 PS2, Line 1514: # Test creating table with the name after rename it to another > I want to cover the transactional and external tables scenario for the test Slightly simpler to identify if a single case fails. Not a significant concern. -- To view, visit http://gerrit.cloudera.org:8080/22554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I009a87ef5e2c331272f9e2d7a6342cc860e64737 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 07 May 2025 23:48:44 +0000 Gerrit-HasComments: Yes
