Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py@238
PS5, Line 238:     return DEFAULT_QUERY_OPTIONS.copy()
> I'd like to keep it for now, in case I need to backport it.
Can you add a TODO for it, ideally with a Jira number for that?



--
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 08 May 2025 08:48:23 +0000
Gerrit-HasComments: Yes

Reply via email to