Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )
Change subject: IMPALA-14039: __restore_query_options should unset query option ...................................................................... Patch Set 8: (7 comments) Thanks a lot for working on this Riza! I only have some minor comments on the patch. http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@9 PS8, Line 9: attempt nit: attempts http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@10 PS8, Line 10: understand nit: understands http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@12 PS8, Line 12: parse nit: parses http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@18 PS8, Line 18: that nit: that were http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@22 PS8, Line 22: change nit: changes http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py@233 PS8, Line 233: Return nit: Returns http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py@637 PS8, Line 637: , "" Is it true that a default value of empty string is required after this patch? If so, could we elaborate on this a little bit? -- To view, visit http://gerrit.cloudera.org:8080/22862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923 Gerrit-Change-Number: 22862 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 08 May 2025 23:05:08 +0000 Gerrit-HasComments: Yes
