Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )
Change subject: IMPALA-14039: __restore_query_options should unset query option ...................................................................... Patch Set 9: (1 comment) > Patch Set 8: > > (7 comments) > > Thanks a lot for working on this Riza! > > I only have some minor comments on the patch. Hi Fang-Yu, I'm sorry, the GVO has already run when you left your comments. http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py@637 PS8, Line 637: , "" > Is it true that a default value of empty string is required after this patc It is not. It just a default value to say we don't need to populate the query_options dictionary if value given is an empty string. -- To view, visit http://gerrit.cloudera.org:8080/22862 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923 Gerrit-Change-Number: 22862 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 09 May 2025 00:56:24 +0000 Gerrit-HasComments: Yes
