Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22245 )
Change subject: IMPALA-13624: Implement textual representation for aggregate event sequences ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/22245/13/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json File testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json: http://gerrit.cloudera.org:8080/#/c/22245/13/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_extended.expected.pretty.json@3024 PS13, Line 3024: 1135987328.0, 1139987328.0, 0.0, 0.0, 1147987200.0 > The values are consistent with each run, the precision was changed from dou It is probably better to leave as double and truncate the decimals with formatting. Float can be imprecise for large numbers. -- To view, visit http://gerrit.cloudera.org:8080/22245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0 Gerrit-Change-Number: 22245 Gerrit-PatchSet: 13 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 09 May 2025 11:42:29 +0000 Gerrit-HasComments: Yes
