Surya Hebbar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22245 )

Change subject: IMPALA-13624: Implement textual representation for aggregate 
event sequences
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22245/13/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt
File 
testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt:

http://gerrit.cloudera.org:8080/#/c/22245/13/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats_default.expected.txt@5922
PS13, Line 5922:          - Prepare Finished: 3.999ms
               :          - Open Finished: 3s819ms
               :          - First Batch Produced: 3s819ms
               :          - First Batch Sent: 3s819ms
               :          - ExecInternal Finished: 3s819ms
> Why the delta, number in parentheses, lost in this case?
Fragment Instance Lifecycle Event Timeline :
- Open Started: 2s850ms, 3s850ms, 4s150ms, 5s850ms
- Open Finished: 4s094ms, 5s850ms, 6s150ms, 7s850ms
- First Batch Requested: 8s094ms, 9s850ms, 10s150ms, 11s850ms
- First Batch Returned:  ... ... ... ... ... ...
- ... ... ... ... ... ... ... ...

This fragment only has a single instance, when multiple instances are present 
in a fragment, deltas are not currently printed.

The related code begins from
https://gerrit.cloudera.org/#/c/22245/13/be/src/util/runtime-profile.cc#2888

To represent deltas or derived info, a separate case needs to be carved out for 
a fragment with a single instance.



--
To view, visit http://gerrit.cloudera.org:8080/22245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0
Gerrit-Change-Number: 22245
Gerrit-PatchSet: 13
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Comment-Date: Fri, 09 May 2025 10:14:05 +0000
Gerrit-HasComments: Yes

Reply via email to