Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/22640 )
Change subject: IMPALA-13850 (part 3): Implement in-place reset for CatalogD ...................................................................... Patch Set 33: (2 comments) http://gerrit.cloudera.org:8080/#/c/22640/33/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/22640/33/fe/src/main/java/org/apache/impala/catalog/Catalog.java@29 PS33, Line 29: import java.util.concurrent.atomic.AtomicReference; We don't need this now? http://gerrit.cloudera.org:8080/#/c/22640/33/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22640/33/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2538 PS33, Line 2538: completedInitialReset_ = true; This would be set to true even in the case of an exception as well. so should this be the last line in try block? -- To view, visit http://gerrit.cloudera.org:8080/22640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4ae2154612746b34484391c5950e74b61f85c9d Gerrit-Change-Number: 22640 Gerrit-PatchSet: 33 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 12 May 2025 19:56:35 +0000 Gerrit-HasComments: Yes
