Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22640 )
Change subject: IMPALA-13850 (part 3): Implement in-place reset for CatalogD ...................................................................... Patch Set 34: (2 comments) http://gerrit.cloudera.org:8080/#/c/22640/33/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/22640/33/fe/src/main/java/org/apache/impala/catalog/Catalog.java@29 PS33, Line 29: import javax.annotation.Nullable; > We don't need this now? Done http://gerrit.cloudera.org:8080/#/c/22640/33/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22640/33/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2538 PS33, Line 2538: triggeredInitialReset_ = true; // set to true, regardless of succes status. > This would be set to true even in the case of an exception as well. so shou It is indeed intended to set to True once initial reset is triggered. The flag is intended just to block any Db lookup until at least 1 reset has been done, regardless if Exception is ever thrown during reset() or not. The first reset is special, triggered by CatalogServer::TriggerResetMetadata(). If initial reset throws Exception, Db lookup should be served, regardless of the end state of dbCache_. Renamed the variable to triggeredInitialReset_. -- To view, visit http://gerrit.cloudera.org:8080/22640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4ae2154612746b34484391c5950e74b61f85c9d Gerrit-Change-Number: 22640 Gerrit-PatchSet: 34 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 12 May 2025 23:24:10 +0000 Gerrit-HasComments: Yes
