Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22897 )
Change subject: IMPALA-14071: Refactor MathUtil.saturatingMultiplyCardinalities() ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/22897/3/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/22897/3/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@449 PS3, Line 449: checkedMultiply > checkedMultiply is a static method and thus should be called everywhere in Make sense. However, there are already pre-existing call-sites that invoke checkedMultiply this way. I'd like to avoid making unnecessary changes if possible. http://gerrit.cloudera.org:8080/#/c/22897/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/22897/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2814 PS3, Line 2814: a simple in-li > Should be PlanNode.checkedMultiply Same reason as https://gerrit.cloudera.org/c/22897/3/fe/src/main/java/org/apache/impala/planner/AggregationNode.java#449 http://gerrit.cloudera.org:8080/#/c/22897/3/fe/src/test/java/org/apache/impala/util/MathUtilTest.java File fe/src/test/java/org/apache/impala/util/MathUtilTest.java: http://gerrit.cloudera.org:8080/#/c/22897/3/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@49 PS3, Line 49: testSaturatingMultiplyCardinality > Rename this test since it no longer tests the saturatingMultiplyCardinaliti Ack. Will do. http://gerrit.cloudera.org:8080/#/c/22897/3/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@67 PS3, Line 67: unknown + " * " + unknown, unknown, PlanNode.checkedMultiply(unknown, unknown)); > This test should have a fourth and fifth case: Ack. Will do. -- To view, visit http://gerrit.cloudera.org:8080/22897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505ab11cfa1024feb4ceac4cffe9c3283be228ce Gerrit-Change-Number: 22897 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 14 May 2025 15:44:32 +0000 Gerrit-HasComments: Yes
