Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22897 )
Change subject: IMPALA-14071: Refactor MathUtil.saturatingMultiplyCardinalities() ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22897/5/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/22897/5/fe/src/main/java/org/apache/impala/planner/PlanNode.java@969 PS5, Line 969: checkedAdd > nit: the names checkedAdd() and checkedMultiply() can be a bit confusing, a I don't mind changing the name. It will make the change bigger though. Considering Jason's feedback earlier about static method, maybe it is best to move these method to MathUtil instead, so there is no confusion about the method invocation. -- To view, visit http://gerrit.cloudera.org:8080/22897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505ab11cfa1024feb4ceac4cffe9c3283be228ce Gerrit-Change-Number: 22897 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 May 2025 16:51:41 +0000 Gerrit-HasComments: Yes
