Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22897 )
Change subject: IMPALA-14071: Refactor helper methods around cardinality bounding ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/22897/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22897/8//COMMIT_MSG@7 PS8, Line 7: Refactor helper methods around cardinality bounding > change the title since the patch include more changes Done http://gerrit.cloudera.org:8080/#/c/22897/9/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test File testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test: http://gerrit.cloudera.org:8080/#/c/22897/9/testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test@978 PS9, Line 978: Resource Estimates: Memory=85MB > What cause estimate memory changes? It is this change in ExchangeNode https://gerrit.cloudera.org/c/22897/9/fe/src/main/java/org/apache/impala/planner/ExchangeNode.java#347 Should avoid the IF block if cardinality is negative or numNodes is not positive number and not partitioned exchange. -- To view, visit http://gerrit.cloudera.org:8080/22897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505ab11cfa1024feb4ceac4cffe9c3283be228ce Gerrit-Change-Number: 22897 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 May 2025 20:28:16 +0000 Gerrit-HasComments: Yes
