Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22897 )
Change subject: IMPALA-14071: Refactor helper methods around cardinality bounding ...................................................................... Patch Set 10: Code-Review+2 (13 comments) http://gerrit.cloudera.org:8080/#/c/22897/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22897/8//COMMIT_MSG@38 PS8, Line 38: Pass Following FE and EE tests: > Done Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/main/java/org/apache/impala/planner/PlanNode.java@87 PS8, Line 87: private final static Logger LOG = LoggerFactory.getLogger(PlanNode.class); > It is still used within this class. I change it to private. Ack http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java File fe/src/test/java/org/apache/impala/util/MathUtilTest.java: http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@56 PS8, Line 56: > Changed to use LongMath.saturatedMultiply(). Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@75 PS8, Line 75: fail("Expected IllegalArgumentException"); > Done Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@79 PS8, Line 79: own and > Done Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@82 PS8, Line 82: fail("Expected IllegalArgumentException"); > Done Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@110 PS8, Line 110: > Changed to use LongMath.saturatedAdd(). Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@127 PS8, Line 127: fail("Expected IllegalArgumentException"); > Need to assert e.getMessage() Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@131 PS8, Line 131: unknow > Done Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@134 PS8, Line 134: fail("Expected IllegalArgumentException"); > Done Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@166 PS8, Line 166: fail("Expected IllegalArgumentException"); > Done Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@170 PS8, Line 170: // Case 5: first argument is unknown and second argument is invalid. > Done Done http://gerrit.cloudera.org:8080/#/c/22897/8/fe/src/test/java/org/apache/impala/util/MathUtilTest.java@173 PS8, Line 173: fail("Expected IllegalArgumentException"); > Done Done -- To view, visit http://gerrit.cloudera.org:8080/22897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I505ab11cfa1024feb4ceac4cffe9c3283be228ce Gerrit-Change-Number: 22897 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 May 2025 21:44:19 +0000 Gerrit-HasComments: Yes
