Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22873 )
Change subject: IMPALA-14014: Fix COMPUTE STATS with TABLESAMPLE clause ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22873/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/22873/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@808 PS3, Line 808: throw new AnalysisException("TABLESAMPLE is only supported on HDFS and " + : "Iceberg tables."); Please check if these need to change: fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java:808: throw new AnalysisException("TABLESAMPLE is only supported on HDFS tables."); fe/src/main/java/org/apache/impala/analysis/TableRef.java:485: "TABLESAMPLE is only supported on HDFS tables: " + getUniqueAlias()); fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:1885: "TABLESAMPLE is only supported on HDFS tables."); fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:1887: "TABLESAMPLE is only supported on HDFS tables."); fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:1890: "TABLESAMPLE is only supported on HDFS tables."); fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:1902: "TABLESAMPLE is only supported on HDFS tables."); fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:1904: "TABLESAMPLE is only supported on HDFS tables."); fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:1907: "TABLESAMPLE is only supported on HDFS tables."); fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:396: "TABLESAMPLE is only supported on HDFS tables: functional_kudu.alltypes"); fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:398: "TABLESAMPLE is only supported on HDFS tables: functional_hbase.alltypes"); fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:400: "TABLESAMPLE is only supported on HDFS tables: " + fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:404: "TABLESAMPLE is only supported on HDFS tables: v"); fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:407: "TABLESAMPLE is only supported on HDFS tables: v"); fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:409: "TABLESAMPLE is only supported on HDFS tables: functional.alltypes_view"); fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:412: "TABLESAMPLE is only supported on HDFS tables: " + fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:416: "TABLESAMPLE is only supported on HDFS tables: a.int_array_col"); -- To view, visit http://gerrit.cloudera.org:8080/22873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d5fc1374ab69209a74f2488bcb9a7d510b782 Gerrit-Change-Number: 22873 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 21 May 2025 14:25:21 +0000 Gerrit-HasComments: Yes
