Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22873 )
Change subject: IMPALA-14014: Fix COMPUTE STATS with TABLESAMPLE clause ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22873/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/22873/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@808 PS3, Line 808: throw new AnalysisException("TABLESAMPLE is only supported on HDFS and " + : "Iceberg tables."); > Please check if these need to change: You're right. I also fixed the error message to "TABLESAMPLE is only supported on file-based tables" http://gerrit.cloudera.org:8080/#/c/22873/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22873/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@347 PS3, Line 347: for (Map.Entry<Long, List<FileDescriptor>> entry : dataFilesWithDeletesSample.entrySet()) { > line too long (95 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/22873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie59d5fc1374ab69209a74f2488bcb9a7d510b782 Gerrit-Change-Number: 22873 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 May 2025 15:36:38 +0000 Gerrit-HasComments: Yes
