Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java File java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java: http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@18 PS4, Line 18: package org.apache.impala.planner; > Two things here: Done http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@105 PS4, Line 105: //setupAdmissionControl(); > One of the differences from the regular TpcdsCpuCostPlannerTest is that we I just overlooked this on my first pass because I wanted to simplify things to get them to work. Latest patch now uses this. I did copy over the resource files rather than try to reuse them. Are you ok with this? It was easier to just make a new copy and I think it might make sense anyway, but I can reuse if you think it's better. -- To view, visit http://gerrit.cloudera.org:8080/22864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf Gerrit-Change-Number: 22864 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 23 May 2025 17:18:42 +0000 Gerrit-HasComments: Yes
