Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22864 )
Change subject: IMPALA-14041: Enable planner tests ...................................................................... Patch Set 7: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java File java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java: http://gerrit.cloudera.org:8080/#/c/22864/4/java/calcite-planner/src/test/java/org/apache/impala/TpcdsCpuCostPlannerTest.java@105 PS4, Line 105: > I just overlooked this on my first pass because I wanted to simplify things Memory bounding looks good after proper admission control setup. http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java File java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java: http://gerrit.cloudera.org:8080/#/c/22864/7/java/calcite-planner/src/test/java/org/apache/impala/calcite/planner/TpcdsCpuCostPlannerTest.java@57 PS7, Line 57: // Pool definitions and includes memory resource limits, copied to a temporary file : private static final String ALLOCATION_FILE = "fair-scheduler-3-groups.xml"; : : // Contains per-pool configurations for maximum number of running queries and queued : // requests. : private static final String LLAMA_CONFIG_FILE = "llama-site-3-groups.xml"; nit: maybe also comment that these are copied from ./fe/src/test/resources/fair-scheduler-3-groups.xml and ./fe/src/test/resources/llama-site-3-groups.xml accordingly. So we remember to update one, when the other changed. -- To view, visit http://gerrit.cloudera.org:8080/22864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaab4e9068bb64e9a9ee12d83cd2b6b55b99b9bf Gerrit-Change-Number: 22864 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Sat, 24 May 2025 04:00:41 +0000 Gerrit-HasComments: Yes
