Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22950 )
Change subject: [WIP] IMPALA-13986: Update JS scripts to align with linting rules ...................................................................... Patch Set 2: (397 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/queries/profileParseWorker.test.js File tests/webui/js_tests/queries/profileParseWorker.test.js: http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/queries/profileParseWorker.test.js@18 PS2, Line 18: import {describe, test, expect} from '@jest/globals'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/queries/profileParseWorker.test.js@19 PS2, Line 19: import {readFileSync} from 'node:fs'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/queries/profileParseWorker.test.js@29 PS2, Line 29: import("pako.min.js").then((pako) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/queries/profileParseWorker.test.js@30 PS2, Line 30: pako =pako.default; Assignment to function parameter 'pako'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/queries/profileParseWorker.test.js@30 PS2, Line 30: pako =pako.default; Operator '=' must be spaced. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/queries/profileParseWorker.test.js@31 PS2, Line 31: expect(pako.inflate(pako.deflate(exampleJSONProfileText, {level : 3}), {to : "string"})) This line has a length of 94. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js File tests/webui/js_tests/query_timeline/chart_commons.test.js: http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@18 PS2, Line 18: import {describe, test, expect} from '@jest/globals'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@21 PS2, Line 21: 'scripts/query_timeline/chart_commons.js'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@29 PS2, Line 29: "profile_name":"Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@29 PS2, Line 29: "profile_name":"Per Node Profiles", Missing space before value for key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@30 PS2, Line 30: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@31 PS2, Line 31: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@33 PS2, Line 33: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@34 PS2, Line 34: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@35 PS2, Line 35: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@36 PS2, Line 36: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@37 PS2, Line 37: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@38 PS2, Line 38: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@39 PS2, Line 39: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@41 PS2, Line 41: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@42 PS2, Line 42: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@43 PS2, Line 43: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@44 PS2, Line 44: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@45 PS2, Line 45: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@47 PS2, Line 47: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@48 PS2, Line 48: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@49 PS2, Line 49: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@50 PS2, Line 50: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@51 PS2, Line 51: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@71 PS2, Line 71: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@72 PS2, Line 72: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@73 PS2, Line 73: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@75 PS2, Line 75: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@76 PS2, Line 76: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@77 PS2, Line 77: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@78 PS2, Line 78: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@79 PS2, Line 79: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@80 PS2, Line 80: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@81 PS2, Line 81: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@83 PS2, Line 83: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@84 PS2, Line 84: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@85 PS2, Line 85: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@86 PS2, Line 86: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@87 PS2, Line 87: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@89 PS2, Line 89: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@90 PS2, Line 90: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@91 PS2, Line 91: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@92 PS2, Line 92: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@93 PS2, Line 93: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@113 PS2, Line 113: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@114 PS2, Line 114: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@115 PS2, Line 115: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@117 PS2, Line 117: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@118 PS2, Line 118: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@119 PS2, Line 119: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@120 PS2, Line 120: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@121 PS2, Line 121: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@122 PS2, Line 122: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@123 PS2, Line 123: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@125 PS2, Line 125: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@126 PS2, Line 126: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@127 PS2, Line 127: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@128 PS2, Line 128: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@129 PS2, Line 129: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@131 PS2, Line 131: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@132 PS2, Line 132: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@133 PS2, Line 133: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@134 PS2, Line 134: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@135 PS2, Line 135: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@168 PS2, Line 168: period: 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@169 PS2, Line 169: num: 2000, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@170 PS2, Line 170: data: "30, 100, 40" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@195 PS2, Line 195: period: 200, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@196 PS2, Line 196: num: 300, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@197 PS2, Line 197: data: "30, 100, 40" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@223 PS2, Line 223: period: 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@224 PS2, Line 224: num: 300, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@225 PS2, Line 225: data: "30, 100, 40" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@250 PS2, Line 250: period: 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@251 PS2, Line 251: num: 300, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@252 PS2, Line 252: data: "30, 100, 40" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@349 PS2, Line 349: expect(values_array).toEqual([DATA_TYPE, 0, null, null, null, null, null, null, null]); This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@358 PS2, Line 358: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@359 PS2, Line 359: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@360 PS2, Line 360: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@362 PS2, Line 362: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@363 PS2, Line 363: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@364 PS2, Line 364: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@365 PS2, Line 365: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@366 PS2, Line 366: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@367 PS2, Line 367: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@368 PS2, Line 368: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@370 PS2, Line 370: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@371 PS2, Line 371: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@372 PS2, Line 372: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@373 PS2, Line 373: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@374 PS2, Line 374: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@376 PS2, Line 376: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@377 PS2, Line 377: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@378 PS2, Line 378: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@379 PS2, Line 379: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@380 PS2, Line 380: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@384 PS2, Line 384: "profile_name": "host-1:27001", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@385 PS2, Line 385: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@386 PS2, Line 386: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@387 PS2, Line 387: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@388 PS2, Line 388: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@389 PS2, Line 389: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@390 PS2, Line 390: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@392 PS2, Line 392: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@393 PS2, Line 393: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@394 PS2, Line 394: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@395 PS2, Line 395: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@396 PS2, Line 396: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@398 PS2, Line 398: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@399 PS2, Line 399: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@400 PS2, Line 400: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@401 PS2, Line 401: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@402 PS2, Line 402: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@406 PS2, Line 406: "profile_name": "host-1:27001", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@407 PS2, Line 407: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@408 PS2, Line 408: "counter_name": "HostCpuIoWaitPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@409 PS2, Line 409: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@410 PS2, Line 410: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@411 PS2, Line 411: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@412 PS2, Line 412: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@414 PS2, Line 414: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@415 PS2, Line 415: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@416 PS2, Line 416: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@417 PS2, Line 417: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@418 PS2, Line 418: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@420 PS2, Line 420: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@421 PS2, Line 421: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@422 PS2, Line 422: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@423 PS2, Line 423: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@424 PS2, Line 424: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@452 PS2, Line 452: ['avg io wait', 0, 0, 0, 0, 210, 0, 0, 0, 0, 0, 30], Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@453 PS2, Line 453: ['avg sys', 0, 936, 2037, 1335,1320, 903, 903, 936, 375, 375, 1311], Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/chart_commons.test.js@454 PS2, Line 454: ['avg user', 0, 936, 2037, 1335, 1320, 903, 903, 936, 375, 375, 1311] Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js File tests/webui/js_tests/query_timeline/fragment_diagram.test.js: http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@18 PS2, Line 18: import {describe, test, expect} from '@jest/globals'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@24 PS2, Line 24: const stroke_fill_colors = { black : "#000000", dark_grey : "#505050", There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@25 PS2, Line 25: light_grey : "#F0F0F0", transperent : "rgba(0, 0, 0, 0)" }; There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@30 PS2, Line 30: '<rect x="0" y="0" width="100" height="100"' Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@31 PS2, Line 31: +` fill="${stroke_fill_colors.transperent}"` Operator '+' must be spaced. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@39 PS2, Line 39: '<line x1="0" y1="0" x2="100" y2="100"' Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@41 PS2, Line 41: + ' stroke-dasharray="2 2"></line>'); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@47 PS2, Line 47: '<text x="0" y="0" style="font-size: 10px;" dominant-baseline="middle" ' Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_diagram.test.js@49 PS2, Line 49: + 'lengthAdjust="spacingAndGlyphs">Text</text>'); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js File tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js: http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@27 PS2, Line 27: "profile_name":"Coordinator Fragment F31", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@27 PS2, Line 27: "profile_name":"Coordinator Fragment F31", Missing space before value for key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@28 PS2, Line 28: "num_children": 1, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@29 PS2, Line 29: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@31 PS2, Line 31: "profile_name": "Instance fe45c9c56d1:efd1b2a70000 (host=host-1:27000)", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@32 PS2, Line 32: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@33 PS2, Line 33: "counter_name": "MemoryUsage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@34 PS2, Line 34: "unit": "BYTES", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@35 PS2, Line 35: "num": 6, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@36 PS2, Line 36: "period": 500, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@37 PS2, Line 37: "data": "12288,12288,12288,12288,12288,12288" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@39 PS2, Line 39: "counter_name": "ThreadUsage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@40 PS2, Line 40: "unit": "UNIT", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@41 PS2, Line 41: "num": 1, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@42 PS2, Line 42: "period": 500, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/fragment_metrics_diagram.test.js@43 PS2, Line 43: "data": "4" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js File tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js: http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@18 PS2, Line 18: import {describe, test, expect} from '@jest/globals'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@28 PS2, Line 28: "profile_name": "Per Node Profiles", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@29 PS2, Line 29: "num_children": 3, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@30 PS2, Line 30: "child_profiles": [ Missing space after key 'child_profiles'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@32 PS2, Line 32: "profile_name": "host-1:27000", Missing space after key 'profile_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@33 PS2, Line 33: "time_series_counters": [{ Missing space after key 'time_series_counters'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@34 PS2, Line 34: "counter_name": "HostCpuUserPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@35 PS2, Line 35: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@36 PS2, Line 36: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@37 PS2, Line 37: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@38 PS2, Line 38: "data": "0,0,0,70,0,0,0,0,0,10" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@40 PS2, Line 40: "counter_name": "HostCpuSysPercentage", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@41 PS2, Line 41: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@42 PS2, Line 42: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@43 PS2, Line 43: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@44 PS2, Line 44: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@46 PS2, Line 46: "counter_name": "HostNetworkRx", Missing space after key 'counter_name'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@47 PS2, Line 47: "unit": "BASIS_POINTS", Missing space after key 'unit'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@48 PS2, Line 48: "num": 59, Missing space after key 'num'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@49 PS2, Line 49: "period": 100, Missing space after key 'period'. http://gerrit.cloudera.org:8080/#/c/22950/2/tests/webui/js_tests/query_timeline/host_utilization_diagram.test.js@50 PS2, Line 50: "data": "312,679,445,440,301,301,312,125,125,437" Missing space after key 'data'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js File www/scripts/common_util.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@19 PS2, Line 19: const units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@19 PS2, Line 19: const units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@19 PS2, Line 19: const units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@19 PS2, Line 19: const units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@19 PS2, Line 19: const units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@19 PS2, Line 19: const units = ['B', 'KB', 'MB', 'GB', 'TB', 'PB']; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@20 PS2, Line 20: let current_unit= 0; Operator '=' must be spaced. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@22 PS2, Line 22: value = value / 1e3; Assignment to function parameter 'value'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@25 PS2, Line 25: return value.toFixed(precision) + ' ' + units[current_unit]; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@30 PS2, Line 30: return getReadableTimeMS(value / 1000000) Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@32 PS2, Line 32: return (value / 1000000).toFixed(3) + "ms" Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@34 PS2, Line 34: return (value / 1000).toFixed(3) + "us" Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@36 PS2, Line 36: return value + "ns" Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@46 PS2, Line 46: re += (Math.floor(value / 3600000) + "h"); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@47 PS2, Line 47: value = value % 3600000; Assignment to function parameter 'value'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@51 PS2, Line 51: re += (Math.floor(value / 60000) + "m"); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@52 PS2, Line 52: value = value % 60000; Assignment to function parameter 'value'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@58 PS2, Line 58: re += (Math.floor(value / 1000) + "s"); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@59 PS2, Line 59: value = value % 1000; Assignment to function parameter 'value'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@65 PS2, Line 65: value = "0" + value; Assignment to function parameter 'value'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@68 PS2, Line 68: re += (value + "ms") Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@68 PS2, Line 68: re += (value + "ms") Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@78 PS2, Line 78: function renderSize(data, type, row) { 'renderSize' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@78 PS2, Line 78: function renderSize(data, type, row) { 'row' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@80 PS2, Line 80: if (type === 'display' || type === 'filter') { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@80 PS2, Line 80: if (type === 'display' || type === 'filter') { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@91 PS2, Line 91: function renderTime(data, type, row) { 'renderTime' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@91 PS2, Line 91: function renderTime(data, type, row) { 'row' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@93 PS2, Line 93: if (type === 'display' || type === 'filter') { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@93 PS2, Line 93: if (type === 'display' || type === 'filter') { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@104 PS2, Line 104: function getQueryID() { Expected to return a value at the end of function 'getQueryID'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/common_util.js@104 PS2, Line 104: function getQueryID() { 'getQueryID' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/compression_util.js File www/scripts/compression_util.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/compression_util.js@20 PS2, Line 20: export function inflateParseJSON(deflated_string){ Missing space before opening brace. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/queries/profileParseWorker.js File www/scripts/queries/profileParseWorker.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/queries/profileParseWorker.js@21 PS2, Line 21: self.onmessage = (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/queries/profileParseWorker.js@57 PS2, Line 57: } Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/chart_commons.js File www/scripts/query_timeline/chart_commons.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/chart_commons.js@49 PS2, Line 49: timesamples_array[k + 1] = (k * AVG_PERIOD); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/chart_commons.js@94 PS2, Line 94: parent_profile.child_profiles.forEach((time_series_profiles) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/chart_commons.js@116 PS2, Line 116: parent_element.style.display ="flex"; Operator '=' must be spaced. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/chart_commons.js@137 PS2, Line 137: if (typeof process !== "undefined" && process.env.NODE_ENV === 'test') { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@26 PS2, Line 26: import {showTooltip, hideTooltip} from "./chart_commons.js" Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@34 PS2, Line 34: const stroke_fill_colors = { black : "#000000", dark_grey : "#505050", There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@35 PS2, Line 35: light_grey : "#F0F0F0", transperent : "rgba(0, 0, 0, 0)" }; There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@47 PS2, Line 47: { color: "#C0C0FF", label: "Prepare" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@47 PS2, Line 47: { color: "#C0C0FF", label: "Prepare" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@47 PS2, Line 47: { color: "#C0C0FF", label: "Prepare" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@47 PS2, Line 47: { color: "#C0C0FF", label: "Prepare" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@48 PS2, Line 48: { color: "#E0E0E0", label: "Open" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@48 PS2, Line 48: { color: "#E0E0E0", label: "Open" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@48 PS2, Line 48: { color: "#E0E0E0", label: "Open" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@48 PS2, Line 48: { color: "#E0E0E0", label: "Open" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@49 PS2, Line 49: { color: "#FFFFC0", label: "Produce First Batch" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@49 PS2, Line 49: { color: "#FFFFC0", label: "Produce First Batch" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@49 PS2, Line 49: { color: "#FFFFC0", label: "Produce First Batch" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@49 PS2, Line 49: { color: "#FFFFC0", label: "Produce First Batch" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@50 PS2, Line 50: { color: "#C0FFFF", label: "Send First Batch" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@50 PS2, Line 50: { color: "#C0FFFF", label: "Send First Batch" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@50 PS2, Line 50: { color: "#C0FFFF", label: "Send First Batch" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@50 PS2, Line 50: { color: "#C0FFFF", label: "Send First Batch" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@51 PS2, Line 51: { color: "#C0FFC0", label: "Process Remaining Batches" }, There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@51 PS2, Line 51: { color: "#C0FFC0", label: "Process Remaining Batches" }, Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@51 PS2, Line 51: { color: "#C0FFC0", label: "Process Remaining Batches" }, Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@51 PS2, Line 51: { color: "#C0FFC0", label: "Process Remaining Batches" }, There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@52 PS2, Line 52: { color: "#FFC0C0", label: "Close" } There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@52 PS2, Line 52: { color: "#FFC0C0", label: "Close" } Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@52 PS2, Line 52: { color: "#FFC0C0", label: "Close" } Missing space after key 'label'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@52 PS2, Line 52: { color: "#FFC0C0", label: "Close" } There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@155 PS2, Line 155: () => ({count: 0, min : Infinity, max : -Infinity, avg : 0})); Missing space after key 'count'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@161 PS2, Line 161: k = ((ts - min) * BUCKET_SIZE / EVENT_SPAN_T) | 0; Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@186 PS2, Line 186: function DrawBars(svg, rownum, row_height, events, xoffset, px_per_ns) { 'rownum' is already declared in the upper scope on line 41 column 5. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@202 PS2, Line 202: let plan_node = getSvgGroup(); 'plan_node' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@214 PS2, Line 214: events.map((ev) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@227 PS2, Line 227: for (let i = LAST_E_INDEX; i >= 0; --i) { 'i' is already declared in the upper scope on line 219 column 7. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@237 PS2, Line 237: dy = (part.count / events[i].ts_list.length) * BAR_HEIGHT; Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@297 PS2, Line 297: phases.forEach((p) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@305 PS2, Line 305: phases_header.appendChild(getSvgText(p.label, stroke_fill_colors.black, x + PHASE_WIDTH This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@323 PS2, Line 323: let pending_fragments = []; 'pending_fragments' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@324 PS2, Line 324: let fevents = fragment.events; 'fevents' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@326 PS2, Line 326: let frag_name = fragment.name.replace("Coordinator ", "").replace("Fragment ", ""); 'frag_name' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@332 PS2, Line 332: let fragment_svg_group = getSvgGroup(); 'fragment_svg_group' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@336 PS2, Line 336: let node = fragment.nodes[i]; 'node' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@362 PS2, Line 362: let label_x = frag_name_width + CHAR_WIDTH * pending_children; 'label_x' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@363 PS2, Line 363: let label_width = Math.min(CHAR_WIDTH * node.name.length, 'label_width' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@369 PS2, Line 369: let y = ROW_HEIGHT * node.parent_node.rendering.rownum; 'y' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@371 PS2, Line 371: let x = name_width + Math.min.apply(null, fevents[3].ts_list) * PX_PER_NS; 'x' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@377 PS2, Line 377: let x2 = name_width + Math.max.apply(null, fevents[4].ts_list) * PX_PER_NS; 'x2' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@384 PS2, Line 384: let x = name_width - (pending_senders) * CHAR_WIDTH - CHAR_WIDTH / 2; 'x' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@384 PS2, Line 384: let x = name_width - (pending_senders) * CHAR_WIDTH - CHAR_WIDTH / 2; Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@396 PS2, Line 396: let x = frag_name_width + (pending_children + 1) * CHAR_WIDTH - 'x' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@402 PS2, Line 402: node.rendering = { rownum: rownum_l, label_end: label_x + label_width }; There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@402 PS2, Line 402: node.rendering = { rownum: rownum_l, label_end: label_x + label_width }; Missing space after key 'rownum'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@402 PS2, Line 402: node.rendering = { rownum: rownum_l, label_end: label_x + label_width }; Missing space after key 'label_end'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@402 PS2, Line 402: node.rendering = { rownum: rownum_l, label_end: label_x + label_width }; There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@405 PS2, Line 405: pending_children += (node.num_children - node.is_receiver); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@412 PS2, Line 412: printFragment(fragments[node.sender_frag_index]) Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@419 PS2, Line 419: fragment_svg_group.addEventListener('click', updateFragmentMetricsChartOnClick); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@425 PS2, Line 425: fragments.forEach((fragment) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@432 PS2, Line 432: let sec_per_tic = maxts / ntics / 1e9; 'sec_per_tic' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@433 PS2, Line 433: let px_per_tic = chart_width / ntics; 'px_per_tic' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@435 PS2, Line 435: let y = 0; 'y' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@436 PS2, Line 436: let text_y = ROW_HEIGHT - 4; 'text_y' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@464 PS2, Line 464: execution_profile.child_profiles.forEach((fp) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@481 PS2, Line 481: if (fp.child_profiles[instance].event_sequences[0].events.length == Expected '===' and instead saw '=='. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@508 PS2, Line 508: name: fp.profile_name, Missing space after key 'name'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@509 PS2, Line 509: events: fevents, Missing space after key 'events'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@510 PS2, Line 510: nodes: [ ], Missing space after key 'nodes'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@511 PS2, Line 511: color: fragment_colors[color_idx] Missing space after key 'color'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@512 PS2, Line 512: } Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@524 PS2, Line 524: let name_flds = pp.profile_name.split(/[()]/); 'name_flds' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@526 PS2, Line 526: let node_type = name_flds[0].trim(); 'node_type' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@528 PS2, Line 528: let node_id = name_flds.length > 1 ? 'node_id' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@536 PS2, Line 536: let table_name = pp.info_strings.find(({ key }) => key === "Table Name") 'table_name' is never reassigned. Use 'const' instead. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@536 PS2, Line 536: let table_name = pp.info_strings.find(({ key }) => key === "Table Name") There should be no space after '{'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@536 PS2, Line 536: let table_name = pp.info_strings.find(({ key }) => key === "Table Name") There should be no space before '}'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@543 PS2, Line 543: (node_type === "HASH_JOIN_NODE" && pp.num_children < 3); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@545 PS2, Line 545: const IS_SENDER = (node_type === "Hash Join Builder" || Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@576 PS2, Line 576: name: node_name, Missing space after key 'name'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@577 PS2, Line 577: type: node_type, Missing space after key 'type'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@578 PS2, Line 578: node_id: node_id, Missing space after key 'node_id'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@579 PS2, Line 579: num_children: 0, Missing space after key 'num_children'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@580 PS2, Line 580: child_index: 0, Missing space after key 'child_index'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@581 PS2, Line 581: metadata: pp.node_metadata, Missing space after key 'metadata'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@582 PS2, Line 582: parent_node: parent_node, Missing space after key 'parent_node'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@583 PS2, Line 583: events: node_events, Missing space after key 'events'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@584 PS2, Line 584: path: node_path.slice(0), Missing space after key 'path'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@585 PS2, Line 585: is_receiver: IS_RECEIVER, Missing space after key 'is_receiver'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@586 PS2, Line 586: is_sender: IS_SENDER Missing space after key 'is_sender'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@587 PS2, Line 587: } Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@632 PS2, Line 632: node.events[en].ts_list.push(cp.event_sequences[0].events[en].timestamp); This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@636 PS2, Line 636: while(i < node.events.length && en < cp.event_sequences[0].events.length) { This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@638 PS2, Line 638: node.events[i].ts_list.push(cp.event_sequences[0].events[en].timestamp); This line has a length of 92. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@661 PS2, Line 661: export function setTimingDiagramDimensions(ignored_arg) { 'ignored_arg' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@697 PS2, Line 697: fragment_diagram.addEventListener('mouseout', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@697 PS2, Line 697: fragment_diagram.addEventListener('mouseout', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@697 PS2, Line 697: fragment_diagram.addEventListener('mouseout', (e) => { 'e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@703 PS2, Line 703: fragment_diagram.addEventListener('mousemove', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@703 PS2, Line 703: fragment_diagram.addEventListener('mousemove', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@704 PS2, Line 704: if (e.clientX + scrollable_screen.scrollLeft >= name_width && e.clientX + scrollable_screen.scrollLeft <= name_width + chart_width){ This line has a length of 134. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@704 PS2, Line 704: if (e.clientX + scrollable_screen.scrollLeft >= name_width && e.clientX + scrollable_screen.scrollLeft <= name_width + chart_width){ Missing space before opening brace. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@706 PS2, Line 706: timestamp_gridline = getSvgLine(stroke_fill_colors.black, e.clientX + scrollable_screen.scrollLeft, 0, e.clientX + scrollable_screen.scrollLeft, This line has a length of 148. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@709 PS2, Line 709: const GRIDLINE_TIME = ((maxts * (e.clientX + scrollable_screen.scrollLeft - name_width) / chart_width) / 1e9); This line has a length of 114. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@709 PS2, Line 709: const GRIDLINE_TIME = ((maxts * (e.clientX + scrollable_screen.scrollLeft - name_width) / chart_width) / 1e9); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@709 PS2, Line 709: const GRIDLINE_TIME = ((maxts * (e.clientX + scrollable_screen.scrollLeft - name_width) / chart_width) / 1e9); Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@716 PS2, Line 716: } catch (e) { 'e' is already declared in the upper scope on line 703 column 49. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@723 PS2, Line 723: fragment_diagram.addEventListener('wheel', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@723 PS2, Line 723: fragment_diagram.addEventListener('wheel', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@747 PS2, Line 747: timeticks_footer.addEventListener('wheel', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@747 PS2, Line 747: timeticks_footer.addEventListener('wheel', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@755 PS2, Line 755: const RENDERING_CONSTRAINT = CHAR_WIDTH * ((decimals + 1) + INTEGER_PART_ESTIMATE) Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@774 PS2, Line 774: plan_order.addEventListener('click', renderFragmentDiagram); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_diagram.js@776 PS2, Line 776: if (typeof process !== "undefined" && process.env.NODE_ENV === 'test') { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js File www/scripts/query_timeline/fragment_metrics_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@19 PS2, Line 19: from "./fragment_diagram.js" Missing semicolon. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@79 PS2, Line 79: format : (x) => x.toFixed(decimals) Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@85 PS2, Line 85: format : (y) => getReadableSize(y, 1) Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@91 PS2, Line 91: format : (y2) => (y2 === Math.floor(y2) ? y2 : "") Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@91 PS2, Line 91: format : (y2) => (y2 === Math.floor(y2) ? y2 : "") Unnecessary parentheses around expression. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@99 PS2, Line 99: value : (value, ratio, id, index) => { 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@100 PS2, Line 100: if (id.includes("memory usage")){ Missing space before opening brace. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@106 PS2, Line 106: title : (x, index) => x.toFixed(decimals) 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@121 PS2, Line 121: const NEXT_HEIGHT = getFragmentMetricsHeight() + (fragment_metrics_resize_bar.offsetTop - This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@135 PS2, Line 135: const fragment_metrics_aggregate = new Array(counters.length); 'fragment_metrics_aggregate' is already declared in the upper scope on line 47 column 5. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@141 PS2, Line 141: const sampled_fragment_metrics_timeseries = new Array(max_samples.allocated + 3) 'sampled_fragment_metrics_timeseries' is already declared in the upper scope on line 48 column 5. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@180 PS2, Line 180: profile_fragments.every((fragment_profile) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@226 PS2, Line 226: fragment_metrics_aggregate.forEach((acc_usage) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@258 PS2, Line 258: const DID_UNLOAD = fragment_metrics_chart.internal.getTargets().every((target) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@296 PS2, Line 296: fragment_metrics_resize_bar.addEventListener('mousedown', Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@297 PS2, Line 297: function dragResizeBarBegin(mousedown_e) { 'mousedown_e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@298 PS2, Line 298: fragment_metrics_resize_bar.removeEventListener('mousedown', dragResizeBarBegin); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@299 PS2, Line 299: document.body.addEventListener('mousemove', dragResizeBar); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@300 PS2, Line 300: document.body.addEventListener('mouseup', function dragResrizeBarEnd() { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@301 PS2, Line 301: document.body.removeEventListener('mouseup', dragResrizeBarEnd); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@302 PS2, Line 302: document.body.removeEventListener('mousemove', dragResizeBar); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@303 PS2, Line 303: fragment_metrics_resize_bar.addEventListener('mousedown', dragResizeBarBegin); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@307 PS2, Line 307: fragment_metrics_close_btn.addEventListener('click', closeFragmentMetricsChart); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/fragment_metrics_diagram.js@312 PS2, Line 312: if (typeof process !== "undefined" && process.env.NODE_ENV === 'test') { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/global_dom.js File www/scripts/query_timeline/global_dom.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/global_dom.js@20 PS2, Line 20: const fs =await import('fs'); Parsing error: Cannot use keyword 'await' outside an async function http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/global_members.js File www/scripts/query_timeline/global_members.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/global_members.js@33 PS2, Line 33: export let maxts =0; Operator '=' must be spaced. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@63 PS2, Line 63: const host_utilization_resize_bar = document.getElementById("host_utilization_resize_bar"); This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@74 PS2, Line 74: for (let i = 0; i < cpu_utilization_counters.length; i++){ Missing space before opening brace. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@82 PS2, Line 82: axes: axis_mappings, Missing space after key 'axes'. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@101 PS2, Line 101: format : (x) => x.toFixed(decimals) Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@107 PS2, Line 107: format : (y) => y + '%' Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@107 PS2, Line 107: format : (y) => y + '%' Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@113 PS2, Line 113: format : (y2) => `${getReadableSize(y2, 1)}/s` Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@121 PS2, Line 121: value : (value, ratio, id, index) => { 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@122 PS2, Line 122: if (cpu_utilization_counter_group.includes(id)){ Missing space before opening brace. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@123 PS2, Line 123: return value.toFixed(decimals) + '%'; Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@128 PS2, Line 128: title : (x, index) => x.toFixed(decimals) + "s" 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@158 PS2, Line 158: const cpu_nodes_usage_aggregate = new Array(counters_y1.length); 'cpu_nodes_usage_aggregate' is already declared in the upper scope on line 50 column 5. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@167 PS2, Line 167: const read_write_metrics_aggregate = new Array(counters_y2.length); 'read_write_metrics_aggregate' is already declared in the upper scope on line 51 column 5. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@174 PS2, Line 174: const sampled_utilization_timeseries = new Array(max_samples.allocated + 2) 'sampled_utilization_timeseries' is already declared in the upper scope on line 52 column 5. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@177 PS2, Line 177: mapTimeseriesCounters(parent_profile.child_profiles[0].time_series_counters, counters_y1); This line has a length of 92. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@178 PS2, Line 178: mapTimeseriesCounters(parent_profile.child_profiles[0].time_series_counters, counters_y2); This line has a length of 92. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@219 PS2, Line 219: if (!host_utilization_visible){ Missing space before opening brace. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@241 PS2, Line 241: if (impala_server_profile.summary_stats_counters[0].num_of_samples == Expected '===' and instead saw '=='. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@267 PS2, Line 267: cpu_nodes_usage_aggregate.forEach((acc_usage) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@273 PS2, Line 273: read_write_metrics_aggregate.forEach((acc_usage) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@288 PS2, Line 288: cpu_nodes_usage_aggregate.forEach((acc_usage) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@291 PS2, Line 291: read_write_metrics_aggregate.forEach((acc_usage) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@311 PS2, Line 311: host_utilization_resize_bar.addEventListener('mousedown', Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@312 PS2, Line 312: function dragResizeBarBegin(mousedown_e) { 'mousedown_e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@313 PS2, Line 313: host_utilization_resize_bar.removeEventListener('mousedown', dragResizeBarBegin); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@314 PS2, Line 314: document.body.addEventListener('mousemove', dragResizeBar); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@315 PS2, Line 315: document.body.addEventListener('mouseup', function dragResrizeBarEnd() { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@316 PS2, Line 316: document.body.removeEventListener('mouseup', dragResrizeBarEnd); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@317 PS2, Line 317: document.body.removeEventListener('mousemove', dragResizeBar); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@318 PS2, Line 318: host_utilization_resize_bar.addEventListener('mousedown', dragResizeBarBegin); Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@322 PS2, Line 322: More than 1 blank line not allowed. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@323 PS2, Line 323: host_utilization_close_btn.addEventListener('click', (e) => { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@323 PS2, Line 323: host_utilization_close_btn.addEventListener('click', (e) => { Unexpected parentheses around single function argument. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@323 PS2, Line 323: host_utilization_close_btn.addEventListener('click', (e) => { 'e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@331 PS2, Line 331: if (typeof process !== "undefined" && process.env.NODE_ENV === 'test') { Strings must use doublequote. http://gerrit.cloudera.org:8080/#/c/22950/2/www/scripts/query_timeline/host_utilization_diagram.js@332 PS2, Line 332: exportedForTest= {initializeUtilizationMetrics}; Operator '=' must be spaced. -- To view, visit http://gerrit.cloudera.org:8080/22950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c8851c3d2f4e95b7eebd61f379361818afca7ea Gerrit-Change-Number: 22950 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 27 May 2025 13:11:38 +0000 Gerrit-HasComments: Yes
