Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22950 )
Change subject: IMPALA-13986: Update JS scripts to align with linting rules ...................................................................... Patch Set 4: (17 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/common_util.js File www/scripts/common_util.js: http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/common_util.js@80 PS4, Line 80: function renderSize(data, type, row) { 'renderSize' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/common_util.js@80 PS4, Line 80: function renderSize(data, type, row) { 'row' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/common_util.js@93 PS4, Line 93: function renderTime(data, type, row) { 'renderTime' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/common_util.js@93 PS4, Line 93: function renderTime(data, type, row) { 'row' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/common_util.js@106 PS4, Line 106: function getQueryID() { 'getQueryID' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_diagram.js@325 PS4, Line 325: const frag_name = fragment.name.replace("Coordinator ", "").replace("Fragment ", ""); This line has a length of 91. Maximum allowed is 90. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_diagram.js@663 PS4, Line 663: export function setTimingDiagramDimensions(ignored_arg) { 'ignored_arg' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_diagram.js@699 PS4, Line 699: fragment_diagram.addEventListener("mouseout", e => { 'e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_metrics_diagram.js File www/scripts/query_timeline/fragment_metrics_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_metrics_diagram.js@99 PS4, Line 99: value : (value, ratio, id, index) => { 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_metrics_diagram.js@100 PS4, Line 100: if (id.includes("memory usage")){ Missing space before opening brace. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_metrics_diagram.js@106 PS4, Line 106: title : (x, index) => x.toFixed(decimals) 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/fragment_metrics_diagram.js@297 PS4, Line 297: function dragResizeBarBegin(mousedown_e) { 'mousedown_e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/global_dom.js File www/scripts/query_timeline/global_dom.js: http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/global_dom.js@20 PS4, Line 20: const fs = await import("fs"); Parsing error: Cannot use keyword 'await' outside an async function http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/host_utilization_diagram.js@122 PS4, Line 122: value : (value, ratio, id, index) => { 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/host_utilization_diagram.js@129 PS4, Line 129: title : (x, index) => x.toFixed(decimals) + "s" 'index' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/host_utilization_diagram.js@315 PS4, Line 315: function dragResizeBarBegin(mousedown_e) { 'mousedown_e' is defined but never used. http://gerrit.cloudera.org:8080/#/c/22950/4/www/scripts/query_timeline/host_utilization_diagram.js@325 PS4, Line 325: host_utilization_close_btn.addEventListener("click", e => { 'e' is defined but never used. -- To view, visit http://gerrit.cloudera.org:8080/22950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c8851c3d2f4e95b7eebd61f379361818afca7ea Gerrit-Change-Number: 22950 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 27 May 2025 20:20:55 +0000 Gerrit-HasComments: Yes
