Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: IMPALA-13820: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 24: (9 comments) http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/rpc/thrift-server.h File be/src/rpc/thrift-server.h: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/rpc/thrift-server.h@312 PS24, Line 312: bool is_external_facing = true, std::string host=""); nit: other code in this file has spaces around '='. http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/rpc/thrift-server.h@604 PS24, Line 604: std::string host_; Struct packing would suggest we should put string above the primitive bool and int32_t types. However this section's already a mess. http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/service/impala-server.cc@3312 PS24, Line 3312: // TODO: allow IPv6 for external frontend? .host(FLAGS_external_interface) When will this TODO be addressed? http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/CMakeLists.txt File be/src/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/CMakeLists.txt@165 PS24, Line 165: SET_SOURCE_FILES_PROPERTIES(${SQUEASEL_SRC_DIR}/squeasel.c nit: this could be updated on the prior line. I believe this would work: PROPERTIES COMPILE_FLAGS "-std=c99 -DUSE_IPV6") http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/network-util.cc@88 PS24, Line 88: char addr_buf[INET6_ADDRSTRLEN + 1]; nit: the +1 doesn't seem to be required, as these lengths include the null terminating byte. See https://stackoverflow.com/a/166157 (or similar answers) and https://pubs.opengroup.org/onlinepubs/009695399/basedefs/netinet/in.h.html. http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/webserver.cc@423 PS24, Line 423: if (!ip_v4_status.ok() && !ip_v6_status.ok()) return ip_v6_status; This only returns if both failed. That means one of listening_spec or listening_spec_v6 could be empty. That would make the formatting on listening_str a little strange. http://gerrit.cloudera.org:8080/#/c/22527/24/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22527/24/tests/common/custom_cluster_test_suite.py@614 PS24, Line 614: """Override ImpalaTestSuite to return 1st impalad of customer cluster.""" "customer cluster"? Should that be "custom cluster"? http://gerrit.cloudera.org:8080/#/c/22527/24/tests/custom_cluster/test_redaction.py File tests/custom_cluster/test_redaction.py: http://gerrit.cloudera.org:8080/#/c/22527/24/tests/custom_cluster/test_redaction.py@93 PS24, Line 93: # TODO: to this in _start_impala_cluster? Can you clean this up? http://gerrit.cloudera.org:8080/#/c/22527/24/tests/metadata/test_event_processing_base.py File tests/metadata/test_event_processing_base.py: http://gerrit.cloudera.org:8080/#/c/22527/24/tests/metadata/test_event_processing_base.py@34 PS24, Line 34: def _run_test_insert_events_impl(cls, suite, unique_database, is_transactional=False): nit: think this means they're not really classmethod anymore. You could probably rewrite them as a standard member function taking 'self'. -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 24 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 29 May 2025 20:55:26 +0000 Gerrit-HasComments: Yes
