Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: IMPALA-13820: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 26: (8 comments) http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/rpc/thrift-server.h File be/src/rpc/thrift-server.h: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/rpc/thrift-server.h@312 PS24, Line 312: bool is_external_facing = true, std::string host = ""); > nit: other code in this file has spaces around '='. Done http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/rpc/thrift-server.h@604 PS24, Line 604: int32_t keepalive_retry_count_ = 0; > Struct packing would suggest we should put string above the primitive bool Moved it near port_ as they are logically grouped together. Reordaring the whole class to be more memory efficient could make backports harder. http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/service/impala-server.cc@3312 PS24, Line 3312: .Build(&server)); > When will this TODO be addressed? I don't think that it needs to be addressed, just left a comment. If someone actually needs ipv6 for external_fe_port then they could add a new flag. http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/network-util.cc@88 PS24, Line 88: char addr_buf[INET6_ADDRSTRLEN]; > nit: the +1 doesn't seem to be required, as these lengths include the null Done http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22527/24/be/src/util/webserver.cc@423 PS24, Line 423: if (!ip_v4_status.ok() && !ip_v6_status.ok()) return ip_v6_status; > This only returns if both failed. That means one of listening_spec or liste Done http://gerrit.cloudera.org:8080/#/c/22527/24/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22527/24/tests/common/custom_cluster_test_suite.py@614 PS24, Line 614: def create_impala_service(cls): > "customer cluster"? Should that be "custom cluster"? Done http://gerrit.cloudera.org:8080/#/c/22527/24/tests/custom_cluster/test_redaction.py File tests/custom_cluster/test_redaction.py: http://gerrit.cloudera.org:8080/#/c/22527/24/tests/custom_cluster/test_redaction.py@93 PS24, Line 93: self.client = self.create_impala_client() > Can you clean this up? done, moved to _start_impala_cluster http://gerrit.cloudera.org:8080/#/c/22527/24/tests/metadata/test_event_processing_base.py File tests/metadata/test_event_processing_base.py: http://gerrit.cloudera.org:8080/#/c/22527/24/tests/metadata/test_event_processing_base.py@34 PS24, Line 34: def _run_test_insert_events_impl(cls, suite, unique_database, is_transactional=False): > nit: think this means they're not really classmethod anymore. You could pro agree, self would be better, but it would be a bigger change see my answer for https://gerrit.cloudera.org/#/c/22527/23/tests/metadata/test_event_processing_base.py@34 -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 26 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 30 May 2025 13:29:45 +0000 Gerrit-HasComments: Yes
