Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22603 )
Change subject: IMPALA-10349: Support constant folding for non ascii strings ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/22603/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22603/9//COMMIT_MSG@42 PS9, Line 42: large polyigons. A follow up commit may refine this, e.g. by polyigons? http://gerrit.cloudera.org:8080/#/c/22603/9//COMMIT_MSG@50 PS9, Line 50: - Added a few tests that push down non-ascii const expressions in nit: double space http://gerrit.cloudera.org:8080/#/c/22603/9/common/thrift/Exprs.thrift File common/thrift/Exprs.thrift: http://gerrit.cloudera.org:8080/#/c/22603/9/common/thrift/Exprs.thrift@121 PS9, Line 121: 1: required binary value; > Changing type of field 'value' from string to binary in TStringLiteral migh This can show up in CatalogObjects.TColumn. That seems like it would make it a breaking change for zero-downtime upgrades. I can't think of a good way to implement this that works with both older and newer catalogd unless we know what version of catalogd we're talking to though. Maybe a 2nd field, then populate "string value" if UTF-8, "binary bytes" if not? Most likely that would fail the catalog operation if we tried to send a TStringLiteral with only bytes filled in to an older catalogd, but that could be an ok failure mode. I think we require that coordinator and executors are all the same version, so the Java <-> C++ translation (and possibility of crashes) wouldn't be a concern. -- To view, visit http://gerrit.cloudera.org:8080/22603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70663457a0b0a3443e586350f0a5996bb75ba64a Gerrit-Change-Number: 22603 Gerrit-PatchSet: 9 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 29 May 2025 21:45:00 +0000 Gerrit-HasComments: Yes
