Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22603 )
Change subject: IMPALA-10349: Support constant folding for non ascii strings ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/22603/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22603/9//COMMIT_MSG@42 PS9, Line 42: large polygons. A follow up commit may refine this, e.g. by > polyigons? Done http://gerrit.cloudera.org:8080/#/c/22603/9//COMMIT_MSG@50 PS9, Line 50: - Added a few tests that push down non-ascii const expressions in > nit: double space Done http://gerrit.cloudera.org:8080/#/c/22603/9/common/thrift/Exprs.thrift File common/thrift/Exprs.thrift: http://gerrit.cloudera.org:8080/#/c/22603/9/common/thrift/Exprs.thrift@121 PS9, Line 121: 1: required binary value; > This can show up in CatalogObjects.TColumn. That seems like it would make i >This can show up in CatalogObjects.TColumn. Another case is THdfsPartition.partitionKeyExprs, which is used very frequently. Btw actually in binary/compact encoding the string and binary type are encoded exactly the same way. https://github.com/apache/thrift/blob/master/doc/specs/thrift-compact-protocol.md -- To view, visit http://gerrit.cloudera.org:8080/22603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70663457a0b0a3443e586350f0a5996bb75ba64a Gerrit-Change-Number: 22603 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 30 May 2025 09:19:24 +0000 Gerrit-HasComments: Yes
