Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 5: (4 comments) Please address the nits and rebase. Then we can try DRY_RUN this. http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@384 PS4, Line 384: ery > I forgot to bring over the comment from the CNF rules file (and delete that Done http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@93 PS4, Line 93: timeline_.markEvent("Expanded nodes"); > Done Done http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java: http://gerrit.cloudera.org:8080/#/c/22870/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java@33 PS4, Line 33: public static void logDebug(Object resultObject, String planString) { > Done Done http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java: http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java@34 PS5, Line 34: if (!LOG.isDebugEnabled()) { : return false; : } nit: if (!LOG.isDebugEnabled()) return; -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 03 Jun 2025 19:22:53 +0000 Gerrit-HasComments: Yes
