Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22870 )
Change subject: IMPALA-14061: Calcite Planner: added Calcite rules ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java: http://gerrit.cloudera.org:8080/#/c/22870/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/LogUtil.java@34 PS5, Line 34: if (!LOG.isDebugEnabled()) { : return false; : } > nit: if (!LOG.isDebugEnabled()) return; Yikes, that wouldn't compile, eh :) -- To view, visit http://gerrit.cloudera.org:8080/22870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6671f7ed298a18965ef0b7a5fc10f4912333a52b Gerrit-Change-Number: 22870 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 03 Jun 2025 20:55:54 +0000 Gerrit-HasComments: Yes
