Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22599 )
Change subject: IMPALA-13795: Support serving webUI content with gzip compression ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/22599/10/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22599/10/be/src/util/webserver.cc@244 PS10, Line 244: vector<uint8_t>& output I think this memory buffer should be tracked by a CharMemTrackerAllocator, derived from process_mem_tracker (look around for ExecEnv::GetInstance()->process_mem_tracker()). Please see similar memory tracking at OutboundRowBatch::PrepareForSend and OutboundRowBatch::TryCompress. See also TrackedString. -- To view, visit http://gerrit.cloudera.org:8080/22599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431088a30337bbef2c8d6e16dd15fb6572db0f15 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 10 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Jun 2025 22:39:56 +0000 Gerrit-HasComments: Yes
