Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22599 )
Change subject: IMPALA-13795: Support serving webUI content with gzip compression ...................................................................... Patch Set 13: (1 comment) > Line 612: Move this initialization to Webserver constructor? ExecEnv is constructed from initializing the Webserver. And Webserver object is always initialized before ExecEnv. So, this initialization cannot be moved into the constructor. http://gerrit.cloudera.org:8080/#/c/22599/12/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22599/12/be/src/util/webserver.cc@604 PS12, Line 604: } : : struct sq_request_info* request_info = sq_get_request_info(connection); : if (request_info->is_ssl) { : oss << "Strict-Transport-Security: max-age=31536000; includeSubDomains" << CRLF; : } : oss << "Content-Type: " << content_type << CRLF; : // Make sure to use sq_write for writing the output, as sq_printf truncates at 8kb : c > Move this initialization to Webserver constructor? I have moved it into "Start()" method now. -- To view, visit http://gerrit.cloudera.org:8080/22599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I431088a30337bbef2c8d6e16dd15fb6572db0f15 Gerrit-Change-Number: 22599 Gerrit-PatchSet: 13 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Jun 2025 16:42:58 +0000 Gerrit-HasComments: Yes
