Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22980 )

Change subject: IMPALA-14075: Add CatalogOpExecutor.icebergExecutorService_
......................................................................


Patch Set 3:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22980/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/22980/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@434
PS3, Line 434:                 new 
ThreadFactoryBuilder().setNameFormat("IcebergCatalogThread-%d").build());
line too long (93 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dcbf1e406e1732ef8829eb0cd627d932291d485
Gerrit-Change-Number: 22980
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 05 Jun 2025 14:33:09 +0000
Gerrit-HasComments: Yes

Reply via email to