Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22980 )
Change subject: IMPALA-14075: Add CatalogOpExecutor.icebergExecutorService_ ...................................................................... Patch Set 4: (1 comment) Thanks! http://gerrit.cloudera.org:8080/#/c/22980/4/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/22980/4/be/src/util/backend-gflag-util.cc@325 PS4, Line 325: static bool ValidatePositiveInt(const char* flagname, int32_t value) { Instead of duplicating the code, this function could dispatch to ValidatePositiveInt64(). -- To view, visit http://gerrit.cloudera.org:8080/22980 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dcbf1e406e1732ef8829eb0cd627d932291d485 Gerrit-Change-Number: 22980 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Jun 2025 14:49:45 +0000 Gerrit-HasComments: Yes
