Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22668
to look at the new patch set (#3).
Change subject: IMPALA-13901: Make histogram/sample/group_concat ineligible for
tuple caching
......................................................................
IMPALA-13901: Make histogram/sample/group_concat ineligible for tuple caching
"histogram" and "sample" rely on the same code as "appx_median"
and incorporate randomness. "group_concat" is entirely dependent
on the order of inputs. This expands tuple caching's list of
ineligible functions to include these variable aggregate functions.
Testing:
- Added test cases to TupleCacheTest for these functions
Change-Id: Ibb017dd4297a3bb219ffed2bd9abc94e6c5b2605
---
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java
2 files changed, 13 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/22668/3
--
To view, visit http://gerrit.cloudera.org:8080/22668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb017dd4297a3bb219ffed2bd9abc94e6c5b2605
Gerrit-Change-Number: 22668
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
