Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22668 )
Change subject: IMPALA-13901: Make histogram/sample/group_concat ineligible for tuple caching ...................................................................... IMPALA-13901: Make histogram/sample/group_concat ineligible for tuple caching "histogram" and "sample" rely on the same code as "appx_median" and incorporate randomness. "group_concat" is entirely dependent on the order of inputs. This expands tuple caching's list of ineligible functions to include these variable aggregate functions. Testing: - Added test cases to TupleCacheTest for these functions Change-Id: Ibb017dd4297a3bb219ffed2bd9abc94e6c5b2605 Reviewed-on: http://gerrit.cloudera.org:8080/22668 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Yida Wu <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java 2 files changed, 13 insertions(+), 4 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Yida Wu: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibb017dd4297a3bb219ffed2bd9abc94e6c5b2605 Gerrit-Change-Number: 22668 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
