Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23174 )

Change subject: IMPALA-14227: In HA failover, passive catalogd should apply 
pending HMS events before being active
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/23174/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23174/2//COMMIT_MSG@15
PS2, Line 15: This patch adds a wait during HA failover to ensure HMS events 
before
            : the failover happens are all applied on the new active catalogd.
> Yeah, that could be a problem. I'm assuming the passive catalogd won't have
Added a timeout. Filed IMPALA-14230 for the catch-up mode.


http://gerrit.cloudera.org:8080/#/c/23174/2/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

http://gerrit.cloudera.org:8080/#/c/23174/2/be/src/catalog/catalog-server.cc@873
PS2, Line 873:       catalog_->RegenerateServiceId();
> Tried to not adding new JNI methods. The sleep is just 1s by default. But y
Extended GetEventProcessorSummary to be able to fetch the latest HMS event id 
from HMS directly.


http://gerrit.cloudera.org:8080/#/c/23174/2/be/src/catalog/catalog-server.cc@879
PS2, Line 879:
> Yeah, I'm assuming EventProcessor won't go into the error state after IMPAL
Done


http://gerrit.cloudera.org:8080/#/c/23174/3/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:

http://gerrit.cloudera.org:8080/#/c/23174/3/fe/src/main/java/org/apache/impala/service/JniCatalog.java@523
PS3, Line 523:     TEventProcessorMetricsSummaryRequest thriftReq =
> line too long (96 > 90)
Done



--
To view, visit http://gerrit.cloudera.org:8080/23174
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf4fcb0e27c14197f79625749949b47c033a5f31
Gerrit-Change-Number: 23174
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Wed, 16 Jul 2025 05:56:19 +0000
Gerrit-HasComments: Yes

Reply via email to