Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23174 )
Change subject: IMPALA-14227: In HA failover, passive catalogd should apply pending HMS events before being active ...................................................................... Patch Set 5: Code-Review+1 (3 comments) I just have nits. Feel free to address or skip them as you see fit. http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc@188 PS5, Line 188: transiting nit: transitioning? http://gerrit.cloudera.org:8080/#/c/23174/5/be/src/catalog/catalog-server.cc@880 PS5, Line 880: void CatalogServer::WaitUntilHmsEventsSynced() { nit: Can we DCHECK that catalog_lock_ is owned here? http://gerrit.cloudera.org:8080/#/c/23174/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/23174/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1425 PS5, Line 1425: try (MetaStoreClient metaStoreClient = catalog_.getMetaStoreClient()) nit: Should we add ThreadNameAnnotator here? -- To view, visit http://gerrit.cloudera.org:8080/23174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4fcb0e27c14197f79625749949b47c033a5f31 Gerrit-Change-Number: 23174 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 16 Jul 2025 14:31:03 +0000 Gerrit-HasComments: Yes
