Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23204 )

Change subject: IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond 
cluster membership recovering
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23204/1/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/23204/1/be/src/scheduling/cluster-membership-mgr.cc@300
PS1, Line 300:       if (current_membership_ != nullptr && 
current_membership_->version > new_state->version) {
line too long (96 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e
Gerrit-Change-Number: 23204
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 21 Jul 2025 23:29:49 +0000
Gerrit-HasComments: Yes

Reply via email to