Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23204 )
Change subject: IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond cluster membership recovering ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc@297 PS2, Line 297: // The recovering membership is never exposed to clients and therefore requires no : // copying. The recovering snapshot could be used to update current snapshot and as a result used for admitting queries and notifying clients once statestore subscriber's post-recovery period has passed. I think this comment is misleading. Do we need to make deep copy? https://github.com/apache/impala/blob/branch-4.5.1/be/src/scheduling/cluster-membership-mgr.cc#L455 `ss_is_recovering` could be false if statestore subscriber has come out of post recovery period and `recovering_membership` could be non null. http://gerrit.cloudera.org:8080/#/c/23204/2/be/src/scheduling/cluster-membership-mgr.cc@300 PS2, Line 300: if (current_membership_ != nullptr : && current_membership_->version > new_state->version) { : new_state->version = current_membership_->version; : } It looks like the issue is that we're maintaining separate snapshots in recovering_membership_ and current_membership_ but we expect a common snapshot version across these. -- To view, visit http://gerrit.cloudera.org:8080/23204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e Gerrit-Change-Number: 23204 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 30 Jul 2025 00:40:43 +0000 Gerrit-HasComments: Yes
