Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23250 )
Change subject: IMPALA-14278: Fix MemTracker data race between ExecEnv and Webserver ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23250/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23250/1/be/src/util/webserver.cc@371 PS1, Line 371: compressed_buffer_mem_tracker_->Close(); > The TSAN issue still happen even after this fix. I have tried a shared_lock on the SendResponse method generating the data race now. Hope this fixes it. If it does not, I will remove the mem tracker. http://gerrit.cloudera.org:8080/#/c/23250/1/be/src/util/webserver.cc@371 PS1, Line 371: compressed_buffer_mem_tracker_->Close(); > Can this happen concurrently with SendResponse()? Should Stop() called firs Done -- To view, visit http://gerrit.cloudera.org:8080/23250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife9198e911e526a9a0e88bdb175b4502a5bc2662 Gerrit-Change-Number: 23250 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 05 Aug 2025 19:23:26 +0000 Gerrit-HasComments: Yes
