Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23250 )
Change subject: IMPALA-14278: Fix MemTracker data race between ExecEnv and Webserver ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23250/2/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23250/2/be/src/util/webserver.cc@637 PS2, Line 637: std::shared_lock<std::shared_mutex> l(compressed_buffer_mem_tracker_lock_); > Holding mutex here will serialize concurrent SendRequest()? I have used a shared_lock here, so it won't be a problem. This was the reason for using a shared_mutex, instead of a general one. -- To view, visit http://gerrit.cloudera.org:8080/23250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife9198e911e526a9a0e88bdb175b4502a5bc2662 Gerrit-Change-Number: 23250 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 05 Aug 2025 19:25:06 +0000 Gerrit-HasComments: Yes
