Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23257 )
Change subject: IMPALA-14276: Fix memory leak by removing AdmissionState on rejection ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23257/3/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23257/3/be/src/scheduling/admission-control-service.cc@215 PS3, Line 215: if (admission_state->admission_done && !admission_state->admit_status.ok()) { : LOG(INFO) << "Query " << req->query_id() : << " was rejected. Removing admission state to free resources."; : discard_result(admission_state_map_.Delete(req->query_id())); : } GetQueryStatus rpc could fail and is retriable so we should make this more robust and not delete the entry right away. http://gerrit.cloudera.org:8080/#/c/23257/3/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23257/3/tests/custom_cluster/test_admission_controller.py@2388 PS3, Line 2388: assert new_total_bytes < old_total_bytes * 1.1 I think, in addition we want to check for more specific things like size of admission_state_map_ before and after. It's an internal data structure but maybe we can expose that using debug logs? -- To view, visit http://gerrit.cloudera.org:8080/23257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fba4f176c648ed7811225f7f94c91342a724d10 Gerrit-Change-Number: 23257 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 14:23:37 +0000 Gerrit-HasComments: Yes
