Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23257 )
Change subject: IMPALA-14276: Fix memory leak by removing AdmissionState on rejection ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23257/5/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23257/5/be/src/scheduling/admission-control-service.cc@216 PS5, Line 216: LOG(INFO) << "Query " << req->query_id() : << " was rejected. Removing admission state to free resources."; > nit: IMO, since you already LOG(INFO) here, might as well print state map s The admission_state_map_.Count() seems to be expensive according to the code https://github.com/apache/impala/blob/09a6f0e6cd912f573f0d8950abf40f498385c628/be/src/util/sharded-query-map-util.h#L59. So I used it only for debug logs. -- To view, visit http://gerrit.cloudera.org:8080/23257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fba4f176c648ed7811225f7f94c91342a724d10 Gerrit-Change-Number: 23257 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 21:45:07 +0000 Gerrit-HasComments: Yes
