Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23204 )
Change subject: IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond cluster membership recovering ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23204/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23204/5//COMMIT_MSG@9 PS5, Line 9: This patch fixes a DCHECK failure Mention where the DCHEK is. Is it AdmissionController::ComputeGroupScheduleStates? Please elaborate the problem statement more. Why the DCHECK exist in the first place? Does Admission Control have strong requirement that cluster membership should not change between query queued and admitted? Why failing-followed-by-retrying is not an option? -- To view, visit http://gerrit.cloudera.org:8080/23204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e Gerrit-Change-Number: 23204 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 21:26:43 +0000 Gerrit-HasComments: Yes
