Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10669 )
Change subject: IMPALA-7157: Avoid unnecessarily pretty printing profiles per fragment instance ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/10669/1/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/10669/1/be/src/runtime/fragment-instance-state.cc@a371 PS1, Line 371: : : An alternative we discussed is to bump this log statement to VLOG_ROW() or something higher. That said, it doesn't seem to provide a lot of value to print the profile of a fragment instance in an executor's log esp. in a large cluster. Someone with more historical context of why this was done can feel free to chime in. -- To view, visit http://gerrit.cloudera.org:8080/10669 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0445950385fa6160764feaed9a993fa0e59b242 Gerrit-Change-Number: 10669 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Jun 2018 23:59:51 +0000 Gerrit-HasComments: Yes